[Docs] Complete Public API Documentation #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
thanks! 👏 that was on my list |
|
@jessesquires Want to rip out eventually (as documented) but don't think that's absolutely mandatory right now. For #77 specifically I want to first figure out how we can create a |
Ben-G
force-pushed
the
benji/complete-docs-v1
branch
from
41c7ca6 to
95464a8
Compare
PlanBot-iOS
reviewed
Jan 26, 2018
Sources/TableViewDriver.swift
Outdated
| @@ -163,8 +163,8 @@ open class TableViewDriver: NSObject { | |||
| } | |||
|
|
|||
| self.tableView.registerViews(for: newModel) | |||
|
|
|||
| if self.automaticDiffingEnabled { | |||
|
|
|||
There was a problem hiding this comment.
| Lines should not have trailing whitespace. |
There was a problem hiding this comment.
cc @anayini danger + swiftlint works 😄
Ben-G
force-pushed
the
benji/complete-docs-v1
branch
from
95464a8 to
a69f2b9
Compare
All public symbols that are considered part of the core API are now documented. This commit suppresses documentation for APIs that will be removed in future releases.
Ben-G
force-pushed
the
benji/complete-docs-v1
branch
from
a69f2b9 to
e1ab20c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
All public symbols that are considered part of the core API are now documented.
This commit suppresses documentation for APIs that will be removed in future releases.
cellViewModelsonCollectionViewModelnon-optional.